Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pass required EventBus instance to PDFPageView #83

Merged
merged 1 commit into from
Dec 26, 2020
Merged

fix: Pass required EventBus instance to PDFPageView #83

merged 1 commit into from
Dec 26, 2020

Conversation

fufler
Copy link
Contributor

@fufler fufler commented Dec 24, 2020

Latest version of pdfvuer produces a lot of console errors like this:

[Vue warn]: Error in callback for watcher "scale": "TypeError: Cannot read property 'dispatch' of undefined"

found in

---> <Pdf> at src/Pdfvuer.vue
       <Serve> at dev/serve.vue
         <Root>

This is caused by missing EventBus instance expected by PDFPageView.

Describe the changes you have made in this PR -

Create EventBus instance and pass it to created PDFPageView

Have you updated the readme?

No

Screenshots of the changes (If any) -

N/A

@fufler fufler force-pushed the pass-event-bus-instance-to-pdfpageview branch from 8428f69 to 9eb96aa Compare December 24, 2020 20:55
@arkokoley arkokoley merged commit 9451226 into arkokoley:master Dec 26, 2020
@michaelbukachi
Copy link

@arkokoley Do you have an ETA for the release with this fix?

@arkokoley
Copy link
Owner

@michaelbukachi This has been published as part of 1.7.4.

For the worker you would need to add this line:

import pdfjsWorker from 'pdfjs-dist/build/pdf.worker.entry'

to your component where pdfvuer is used.

Also take a look at the dev/serve.vue.

@michaelbukachi
Copy link

Awesome! Didn't realize that it had been published already. Thought we were still at 1.7.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fufler @michaelbukachi @arkokoley